fix lancedb out for recall after pipeline#1510
Merged
jdye64 merged 9 commits intoNVIDIA:mainfrom Mar 10, 2026
Merged
Conversation
jdye64
reviewed
Mar 10, 2026
|
|
||
| schema = lancedb_schema(2048) | ||
| empty = pa.table({f.name: [] for f in schema}, schema=schema) | ||
| schema = pa.schema( |
Collaborator
There was a problem hiding this comment.
Is something different about this than what is in the new central lancedb_schema function?
Collaborator
Author
There was a problem hiding this comment.
we have a ton of places where we reference lancedb. We need to consolidate. I will change for that call to be used in all functions.
Collaborator
There was a problem hiding this comment.
yes, agreed. Some of the functions that had been centralized seem to have been re-introduced. Lets make some time to tidy this up soon.
Collaborator
|
Unrelated to your changes but upstream changes that were needed previously now cause errors with this PR when running. Can you remove this snippet in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
works on fixing the lancedb search and recall steps in the batch example
Checklist